editing static content for 114 #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addign some new pages, editing others, and updating the strains page for rodents
|
Hi @EreboPSilva .. I think the text on comparative data in Any thoughts (@EreboPSilva and @kamaldodiya) on whether it would be better to suggest a change in this PR or submit a separate pull request? |
twalsh-ebi
reviewed
Jan 6, 2025
As needed for the displaying of the data
EreboPSilva
force-pushed
the
genebuild_static_content
branch
from
cac47ed to
274a42d
Compare
Via misuse of git push --force, accidentally overwrote the changes suggested by @twalsh-ebi and approved by @ens-sb and myself. I replicated the suggestion and [hopefully] fixed the issue.
EreboPSilva
force-pushed
the
genebuild_static_content
branch
from
7f28fa6 to
cb8052b
Compare
to account for newest reference (GRCm39), as suggested by @twalsh-ebi
twalsh-ebi
reviewed
Feb 11, 2025
Co-authored-by: twalsh-ebi <[email protected]>
|
Tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for genebuild content:
addign some new pages, editing others, and updating the strains page for rodents
We havent changed anything from the comparative analysis section on the mouse strains file, and we'd like to check with compara if that's still current and ok, so mentioning here @ens-sb and @twalsh-ebi so that they can offer their view on the topic.
I'd like to also wait for them to approve to merge anything, unless time is of the esence.